Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Make radio jammer block suit sensors #201

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26046: Make radio jammer block suit sensors from space-wizards space-wizards/space-station-14

dce24dfd03b3ddfe1044297edf9d35bc9f75c523

PR opened by nikthechampiongr at 2024-03-12 17:11:18 UTC


PR changed 5 files with 36 additions and 5 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

Radio jammers will now additionally block suit sensors.

When someone with suit sensors is in range of an active radio jammer, their suit sensor output will be jammed. This will lead to them appearing as frozen on any crew monitors for roughly 10 seconds before they completely disappear from it.

Why / Balance

This gives syndies more stealth options when doing their objectives, and provides an interesting use for the radio jammer.

Now on the implementation details:

With this current implementation you drop off suit sensors after roughly 10 seconds of being jammed. This means you get a 10 second period before anyone actively watching crew monitors can even suspect something's wrong. The reason I have it like this is:
a) It's the simplest way to implement this feature.
b) It's more realistic while still providing a pretty significant advantage.

Alternatively this could be changed to make the suit sensors submit outdated info indefinitely until the jammer has stopped.

Technical details

Added a new event which the suit sensors system calls before actually constructing the message it will send to the crew monitoring server. If it is cancelled then the message is not sent. I also intentionally made it so this is checked after a new update time has been set, but if it's a problem it can just be moved above it.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
2024-03-12.19-07-00.mp4

Changelog

🆑

  • tweak: The radio jammer is now able to jam the signal of suit sensors.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 19:12
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@VMSolidus VMSolidus merged commit b0f4304 into Simple-Station:master May 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants